Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for extended tweets #83

Merged
merged 2 commits into from Nov 12, 2021

Conversation

elldritch
Copy link
Contributor

This PR adds a new type TweetMode inside Web.Twitter.Conduit.Parameters that can be used as a ParameterValue for a Param with symbol "tweet_mode". Resolves #60.

I added the tweet_mode parameter symbol to the supports of every APIRequest that returned a Status or something containing a Status (e.g. a RetweetedStatus). I checked for exhaustiveness using the regex APIRequest .*? \[?.*?Status\]?.

I also added an integration test and ran it locally to check that extended mode works as expected.

I also fixed some typos I found.

@himura himura merged commit 6282e61 into himura:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

any plan to support extended tweets?
2 participants