Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Chart> is not a valid SSR component #23

Closed
skanel opened this issue Dec 5, 2020 · 2 comments
Closed

<Chart> is not a valid SSR component #23

skanel opened this issue Dec 5, 2020 · 2 comments
Labels
Status: Abandoned Issue will not be investigated / worked on any further Type: Bug Issue / bug

Comments

@skanel
Copy link

skanel commented Dec 5, 2020

Any solution for this issue?

<Chart> is not a valid SSR component. You may need to review your build config to ensure that dependencies are compiled, rather than imported as pre-compiled modules

@himynameisdave
Copy link
Owner

Duplicate of #14.

As of frappe-charts@1.x, the <Chart /> component can never be a valid SSR component because it relies on the window object in the browser. Perhaps this will be fixed in frappe-charts@2.x, which is currently under development.

Regardless though, this is not an issue with this Svelte wrapper library, but is an issue in the underlying frappe-charts library, so I'll be closing this. Feel free to file an issue over there.

@himynameisdave himynameisdave added Status: Abandoned Issue will not be investigated / worked on any further Type: Bug Issue / bug labels Dec 7, 2020
@melgrove
Copy link

Similar to #14, I fixed this with npm i --save-dev svelte-frappe-charts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Abandoned Issue will not be investigated / worked on any further Type: Bug Issue / bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@himynameisdave @skanel @melgrove