fix: high cardanality of pid_hash #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix (hipages#110) issue, by removing pid_hash and replace by slot label instead. fixed like prometheus best practices want see https://prometheus.io/docs/practices/naming/#labels
fix (hipages#110) issue, by removing pid_hash and replace by child label instead. fixed like prometheus best practices want see https://prometheus.io/docs/practices/naming/#labels
estahn
approved these changes
Nov 21, 2020
|
@all-contributors please add @itcsoft54 for code |
|
I've put up a pull request to add @itcsoft54! 🎉 |
estahn
pushed a commit
that referenced
this pull request
Nov 21, 2020
* fix: high cardanality of pid_hash fix (#110) issue, by removing pid_hash and replace by slot label instead. fixed like prometheus best practices want see https://prometheus.io/docs/practices/naming/#labels * fix: change slot by child label fix (#110) issue, by removing pid_hash and replace by child label instead. fixed like prometheus best practices want see https://prometheus.io/docs/practices/naming/#labels * fix (#110) issue, remove "child" prefix from label "child" value. fixes #110 #76 @all-contributors please add itcsoft54 for code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix (#110) issue, by removing pid_hash and replace by slot label instead.
fixed like prometheus best practices want
see https://prometheus.io/docs/practices/naming/#labels
May need to update Grafana dashboard to replace pid_hash by slot, and use label to group by if need