fix: Typo FPM_REQUEST_INFO #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch break php-fpm_exporter for php 7.2.34, php 7.3.26, still have |
@itcsoft54 You are right. Implemented Fallback in 269acb5 |
|
@estahn Would be great if you can review/merge this change ✌️ |
|
@stchr Thanks for this Simon. Can you sync with the latest master? This should resolve the test issue. |
See `[FPM_REQUEST_INFO] = "Getting request information",` in https://github.com/php/php-src/blob/07fa13088e1349f4b5a044faeee57f2b34f6b6e4/sapi/fpm/fpm/fpm_request.c#L27
|
@estahn master sync is done 💪 |
estahn
approved these changes
May 10, 2021
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@all-contributors add @stchr for bug |
|
I've put up a pull request to add @stchr! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
[FPM_REQUEST_INFO] = "Getting request information",in https://github.com/php/php-src/blob/07fa13088e1349f4b5a044faeee57f2b34f6b6e4/sapi/fpm/fpm/fpm_request.c#L27Otherwise you can get error messages like
Unknown process state 'Getting request information'in php-fpm_exporter.And indeed, "Getting request information" is unknown, as php-fpm_exporter is checking for "Getting request informations" (note the wrong plural "s")
This was changes in PHP >= 7.4 with php/php-src@84b195d
Fixes #137