Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report actual PID #8

Closed
estahn opened this issue Feb 25, 2018 · 1 comment
Closed

Report actual PID #8

estahn opened this issue Feb 25, 2018 · 1 comment
Milestone
v0.3.0

Comments

@estahn
Copy link
Contributor

estahn commented Feb 25, 2018

We currently reporting a hash based on process StartTime and PID as PID. The reason behind this is to uniquely identify processes across multiple containers and on container restarts.

As this might be confusing to some we will change this as follow:

  • Rename label pid for all phpfpm_process_* to hash
  • Label phpfpm_process_* metrics with pid and hash
@estahn estahn added this to the v0.2.1 milestone Feb 28, 2018
@estahn
Copy link
Contributor Author

estahn commented Feb 28, 2018

Released in v0.3.0.

@estahn estahn closed this as completed Feb 28, 2018
@amitsaha amitsaha mentioned this issue Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@estahn