Skip to content

Commit

Permalink
fix: downgrade to v11 (#197)
Browse files Browse the repository at this point in the history
  • Loading branch information
Rukesh-Kapuluru committed Mar 22, 2023
1 parent 6e06460 commit cb3a6b8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions hip_data_tools/google/googleads.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ class GoogleAdsCustomerUtil(AdWordsDataReader):
"""

def __init__(self, conn: GoogleAdsConnectionManager):
super().__init__(conn, service="CustomerService", version="v13")
super().__init__(conn, service="CustomerService", version="v11")

def get_customers(self) -> List[dict]:
"""
Expand Down Expand Up @@ -416,7 +416,7 @@ class GoogleAdsClicksConversionUtil(GoogleAdsUtil):
"""

def __init__(self, conn: GoogleAdsConnectionManager):
super().__init__(conn, type="ClickConversion", version="v13")
super().__init__(conn, type="ClickConversion", version="v11")

def click_conversion(self, data):
"""
Expand Down Expand Up @@ -445,7 +445,7 @@ class GoogleAdsUploadClickConversionsRequestUtil(GoogleAdsUtil):
"""

def __init__(self, conn: GoogleAdsConnectionManager):
super().__init__(conn, type="UploadClickConversionsRequest", version="v13")
super().__init__(conn, type="UploadClickConversionsRequest", version="v11")

def upload_click_conversion(self, customer_id: str, click_conversion):
"""
Expand All @@ -470,7 +470,7 @@ class GoogleAdsConversionActionUtil(GoogleAdsUtil):
"""

def __init__(self, conn: GoogleAdsConnectionManager):
super().__init__(conn, service="ConversionActionService", version="v13")
super().__init__(conn, service="ConversionActionService", version="v11")

def get_conversion_action(self, customer_id: str, conversion_action_id: str):
"""
Expand All @@ -492,7 +492,7 @@ class GoogleAdsOfflineConversionUtil(GoogleAdsUtil):
"""

def __init__(self, conn: GoogleAdsConnectionManager):
super().__init__(conn, service="ConversionUploadService", version="v13")
super().__init__(conn, service="ConversionUploadService", version="v11")
self.required_fields = [
"gclid",
"conversion_action",
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def run_tests(self):
"oauth2client",
"gspread",
"googleads",
"google-ads==20.0.0",
"google-ads==18.0.0",
"numpy",
"mysql-connector-python>=8.0.11, <=8.0.29",
"mysqlclient>=1.3.6,<=2.1",
Expand Down

0 comments on commit cb3a6b8

Please sign in to comment.