New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pagination for fetching users and rooms #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! Could you add a unit test for the room pagination use case? |
@rbergman Sure thing! Added a new commit with some specs. |
artfuldodger
force-pushed
the
support-pagination
branch
from
August 17, 2017 21:02
0053a11
to
73eeed4
Compare
This enables support for pagination, without which it is impossible to get more than 100 rooms or users.
artfuldodger
force-pushed
the
support-pagination
branch
from
August 29, 2017 14:20
73eeed4
to
3c6f725
Compare
@rbergman Need anything from me here to help get this merged? |
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pagination, without which it is impossible to get more than 100 rooms or users.