Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pagination for fetching users and rooms #201

Merged
merged 3 commits into from Aug 29, 2017

Conversation

artfuldodger
Copy link
Contributor

Enable pagination, without which it is impossible to get more than 100 rooms or users.

@coveralls
Copy link

coveralls commented Jun 16, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e7eed9e on bonusly:support-pagination into 4a28188 on hipchat:master.

@rberrelleza
Copy link
Contributor

Thanks! Could you add a unit test for the room pagination use case?

@artfuldodger
Copy link
Contributor Author

@rbergman Sure thing! Added a new commit with some specs.

@coveralls
Copy link

coveralls commented Jun 20, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 0053a11 on bonusly:support-pagination into 4a28188 on hipchat:master.

@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 73eeed4 on bonusly:support-pagination into aaa9350 on hipchat:master.

This enables support for pagination, without which it is impossible
to get more than 100 rooms or users.
@artfuldodger
Copy link
Contributor Author

@rbergman Need anything from me here to help get this merged?

@coveralls
Copy link

coveralls commented Aug 29, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 3c6f725 on bonusly:support-pagination into 359bd59 on hipchat:master.

@rberrelleza rberrelleza merged commit aab95a9 into hipchat:master Aug 29, 2017
@rberrelleza
Copy link
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants