Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed streaming with authentication #1

Closed
wants to merge 1 commit into from
Closed

fixed streaming with authentication #1

wants to merge 1 commit into from

Conversation

Gunni
Copy link
Contributor

@Gunni Gunni commented May 26, 2011

i'm not even sure how this would without auth since i couldn't get my xbmc to start the webserver without auth.

i'm not even sure how this would without auth since i couldn't get my xbmc to
start the webserver without auth.
@hippojay
Copy link
Owner

Thanks - but Does this also work for SMB shared media? What probably needs to be done is something like a:

If protocol == "http":

add XBMC header

else:

don't add header

I also need to work how this passed my testing, although I am working on two plugins at once, with identical codebase, so perhaps I got mixed up.

@Gunni
Copy link
Contributor Author

Gunni commented May 26, 2011

i checked and the "protocol" variable (line 628) seems to have the content "http" when i tested it but the if statement somehow returned false anyways, so i just tried removing the if statement. what is it supposed to contain if it were using smb? (i noticed len(protocol) <= 2, that's just 2 characters, right?).

note though i am a python noob and couldn't find a proper way to test this except running xbmc, test, close it, read log, change something, repeat...

@Gunni Gunni closed this May 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants