-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RGB dtype issue #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
One small inline comment.
Can you paste a screenshot you get with this change for the example from the high-level docs, please? https://hips.readthedocs.io/en/latest/getting_started.html#make-a-color-sky-image
hips/draw/simple.py
Outdated
@@ -63,6 +63,10 @@ def __init__(self, geometry: WCSGeometry, hips_survey: HipsSurveyProperties, til | |||
self._tiles = None | |||
|
|||
@property | |||
def image(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always add a one-line docstring mentioning what it is, what object type is returned, and also add a type annotation.
9f0f797
to
6139a0b
Compare
@adl1995 - You must have been looking at an outdated image on the docs page. |
I had to wipe RTD and trigger a completely fresh build, for the |
@cdeil As discussed on Slack, I have updated the
dtype
so that RGB drawing works fine.