Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RGB dtype issue #73

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Fix RGB dtype issue #73

merged 1 commit into from
Jul 17, 2017

Conversation

adl1995
Copy link
Member

@adl1995 adl1995 commented Jul 17, 2017

@cdeil As discussed on Slack, I have updated the dtype so that RGB drawing works fine.

@cdeil cdeil self-assigned this Jul 17, 2017
@cdeil cdeil added the bug label Jul 17, 2017
@cdeil cdeil added this to the 0.1 milestone Jul 17, 2017
Copy link
Contributor

@cdeil cdeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One small inline comment.

Can you paste a screenshot you get with this change for the example from the high-level docs, please? https://hips.readthedocs.io/en/latest/getting_started.html#make-a-color-sky-image

@@ -63,6 +63,10 @@ def __init__(self, geometry: WCSGeometry, hips_survey: HipsSurveyProperties, til
self._tiles = None

@property
def image(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always add a one-line docstring mentioning what it is, what object type is returned, and also add a type annotation.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.535% when pulling 9f0f797 on adl1995:jpg_tile_draw_issue into 2ab7f7a on hipspy:master.

@adl1995
Copy link
Member Author

adl1995 commented Jul 17, 2017

I just updated the docstring. Here is the output image I'm getting:

jpg_out

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 96.543% when pulling 6139a0b on adl1995:jpg_tile_draw_issue into 2ab7f7a on hipspy:master.

@cdeil cdeil merged commit 0862365 into hipspy:master Jul 17, 2017
@cdeil
Copy link
Contributor

cdeil commented Jul 17, 2017

@adl1995 - You must have been looking at an outdated image on the docs page.
It's all black now: https://hips.readthedocs.io/en/latest//plot_fits.png
I'll make a commit in master shortly to fix.

@cdeil
Copy link
Contributor

cdeil commented Jul 17, 2017

Follow-up commits in master: 9b52a7a and 60a5d95

@cdeil
Copy link
Contributor

cdeil commented Jul 17, 2017

I had to wipe RTD and trigger a completely fresh build, for the plot scripts from the docs build to re-run.
It worked https://readthedocs.org/projects/hips/builds/5698160/ and now the images on
http://hips.readthedocs.io/en/latest/getting_started.html are correct, except for the last remaining drawing issue #74 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants