Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency create-check to ^0.6.0 + Remove support for node 8 #68

Merged
merged 3 commits into from
May 11, 2020
Merged

Update dependency create-check to ^0.6.0 + Remove support for node 8 #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c4c25a
Update dependency create-check to ^0.6.0
renovate-bot May 11, 2020
16cc984
update create check
hipstersmoothie May 11, 2020
499ce78
remove node 8
hipstersmoothie May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

strategy:
matrix:
node-version: [8.x, 10.x, 12.x]
node-version: [10.x, 12.x]

steps:
- uses: actions/checkout@v1
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
"eslint": ">= 5.x"
},
"dependencies": {
"@octokit/rest": "^16.28.7",
"create-check": "^0.5.0",
"create-check": "^0.6.0",
"eslint-formatter-pretty": "^3.0.0"
},
"devDependencies": {
Expand Down
7 changes: 3 additions & 4 deletions src/create-check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import createCheck from 'create-check';
import createCheck, { Annotation } from 'create-check';
import path from 'path';
import Octokit from '@octokit/rest';
import eslint from 'eslint';

const APP_ID = 38817;
Expand Down Expand Up @@ -47,8 +46,8 @@ gd8URXIGc6Nk7ueWMKEZaropIg6q1J7e9qJdlzA6j1fu6vVY3qX3tA==
-----END RSA PRIVATE KEY-----`;

export function createAnnotations(results: eslint.CLIEngine.LintResult[]) {
const annotations: Octokit.ChecksCreateParamsOutputAnnotations[] = [];
const levels: Octokit.ChecksCreateParamsOutputAnnotations['annotation_level'][] = [
const annotations: Annotation[] = [];
const levels: Annotation['annotation_level'][] = [
'notice',
'warning',
'failure'
Expand Down