Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass check name environment variable #150

Conversation

PaulGiletich
Copy link
Contributor

@PaulGiletich PaulGiletich commented Mar 1, 2023

this covers at least two use cases:

  1. For some people the check name may conflict with an existing one, if they are using their own github app.
  2. In some monorepos there are multiple jest runs happening in series for multiple different packages in scope of one codebuild run. Without an ability to override the check name we are stuck with only last package results being reported.

This would allow to work around those

related pr: hipstersmoothie/eslint-formatter-github#113

@PaulGiletich PaulGiletich changed the title Allow to pass env.GITHUB_CHECK_NAME from outside Allow to pass check name environment variable Mar 1, 2023
@PaulGiletich
Copy link
Contributor Author

PaulGiletich commented Mar 2, 2023

@hipstersmoothie i see you've merged my PR with the same change into eslint-formatter-github, thank you!
Can i help somehow to make sure this is merged soon as well? Would appreciate a review

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Mar 2, 2023
@hipstersmoothie hipstersmoothie merged commit 294403e into hipstersmoothie:master Mar 2, 2023
@hipstersmoothie
Copy link
Owner

🚀 PR was released in v1.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants