Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added license information to package info. #56

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

anyt
Copy link
Contributor

@anyt anyt commented Jun 15, 2017

As license information optional, but is highly recommended to supply, it's important to have it in package information if it possible.
documentation ref: https://getcomposer.org/doc/04-schema.md#license

@hiqsol
Copy link
Member

hiqsol commented Jun 15, 2017

Thank you for your efforts!
But I really doubt license information to be of any profit while it takes it's space (very little but still).
I prefer to keep packages files as little as possible cause they are downloaded to users' computers.
Thus we add to packages files only those information that is really necessary to make it functional.

So if there are any reasons tell me, else sorry - no license :)

@rob006
Copy link

rob006 commented Jun 15, 2017

There are tools that checks license of all dependencies for possible violations (for example using GPL library in proprietary app). There is also composer licenses command.

I prefer to keep packages files as little as possible cause they are downloaded to users' computers.

Don't think that these few bytes more will make any difference.

@hiqsol
Copy link
Member

hiqsol commented Jun 16, 2017

There are tools that checks license of all dependencies for possible violations (for example using GPL library in proprietary app). There is also composer licenses command.

Good reason.

Thanks everybody!
Will get to prod eventually.

@hiqsol hiqsol merged commit f4dc2fc into hiqdev:master Jun 16, 2017
@anyt anyt deleted the add_license_information_to_package_info branch March 17, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants