Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP-1945: show Stock deleted #234

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

bladeroot
Copy link
Member

@bladeroot bladeroot commented May 13, 2024

Summary by CodeRabbit

  • New Features
    • Added a new column to enhance server configuration options.
    • Introduced a new search attribute to include deleted items in search results.
    • Updated widget functionality to filter based on item deletion status.

Copy link

coderabbitai bot commented May 13, 2024

Walkthrough

The recent updates involve enhancements to configuration and search capabilities across different components. A new column cdn_traf has been added to server configurations in the web settings, enhancing data tracking. Additionally, the ability to filter search results based on deletion status has been introduced in the model and widget levels, improving user interaction and data management flexibility.

Changes

File Path Change Summary
config/web.php Added cdn_traf column to server configurations.
src/models/.../HubSearch.php
src/widgets/combo/.../HubCombo.php
Introduced show_deleted search attribute and filtering logic.

🐰🌟
In the garden of code, changes bloom,
A new column grows, under the moon's loom.
Search through the thicket, with a new tool,
For hidden data, now easier to pull.
Hop, hop, hop, on the soft green sod,
Celebrate the updates, oh coding squad! 🎉
🐰🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8023f4d and c820a8b.
Files selected for processing (3)
  • config/web.php (1 hunks)
  • src/models/HubSearch.php (1 hunks)
  • src/widgets/combo/HubCombo.php (1 hunks)
Additional comments not posted (4)
src/widgets/combo/HubCombo.php (2)

47-47: Added new public property $showDeleted to handle visibility of deleted or inactive items.


52-66: Updated getFilter method to include handling for $showDeleted. This allows dynamic filtering based on whether deleted items should be shown.

src/models/HubSearch.php (1)

34-34: Added new search attribute 'show_deleted' to improve data retrieval capabilities by including deleted entries in search results.

config/web.php (1)

85-85: Added new column 'cdn_traf' to the server configuration array to enhance tracking or managing CDN traffic.

@SilverFire SilverFire merged commit dce1e04 into hiqdev:master May 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants