Added "server create" functionality #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverFire
requested changes
Jul 11, 2018
src/controllers/ServerController.php
Outdated
| 'collection' => [ | ||
| 'class' => Collection::class, | ||
| 'model' => new ServerForm(), | ||
| 'scenario' => 'create', |
There was a problem hiding this comment.
Лишнее, вот тут это должно делаться по умолчанию
src/controllers/ServerController.php
Outdated
| 'collection' => [ | ||
| 'class' => Collection::class, | ||
| 'model' => new ServerForm(), | ||
| 'scenario' => 'update', |
There was a problem hiding this comment.
Лишнее, вот тут это должно делаться по умолчанию
src/controllers/ServerController.php
Outdated
| 'model' => new ServerForm(), | ||
| 'scenario' => 'create', | ||
| ], | ||
| 'data' => function (Action $action, array $data) { |
There was a problem hiding this comment.
Лучше доработать SmartCreateAction чтобы он по умолчанию добывал модель из коллекции – тогда весь этот код можно удалить
src/controllers/ServerController.php
Outdated
| 'class' => ValidateFormAction::class, | ||
| 'collection' => [ | ||
| 'class' => Collection::class, | ||
| 'model' => Yii::createObject(['class' => ServerForm::class]), |
There was a problem hiding this comment.
Yii::createObject тут не нужен. new будет достаточно
src/forms/ServerForm.php
Outdated
| use hipanel\modules\server\validators\MacValidator; | ||
| use yii\helpers\ArrayHelper; | ||
|
|
||
| class ServerForm extends Server |
src/forms/ServerForm.php
Outdated
|
|
||
| class ServerForm extends Server | ||
| { | ||
| use \hipanel\base\ModelTrait; |
There was a problem hiding this comment.
Родитель уже имеет ModelTrait
src/models/Server.php
Outdated
| ]); | ||
| } | ||
|
|
||
| public function getTypeOptions() |
| use hipanel\widgets\DynamicFormWidget; | ||
| use yii\bootstrap\ActiveForm; | ||
| use yii\bootstrap\Html; | ||
|
|
| $this->params['breadcrumbs'][] = ['label' => Yii::t('hipanel:server', 'Servers'), 'url' => ['index']]; | ||
| $this->params['breadcrumbs'][] = $this->title; | ||
|
|
||
| ?> |
src/views/server/update.php
Outdated
|
|
||
| use yii\helpers\Html; | ||
|
|
||
| $this->title = Yii::t('hipanel', 'Update'); |
SilverFire
approved these changes
Jul 11, 2018
| use yii\bootstrap\ActiveForm; | ||
| use yii\bootstrap\Html; | ||
|
|
||
| /** @var \hipanel\modules\server\forms\ServerForm $model */ |
There was a problem hiding this comment.
В идеале ещё @var \yii\web\View $this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.