Fix #3
Closed
Fix #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change hash
SilverFire
reviewed
Jan 11, 2019
| @@ -50,9 +50,8 @@ public function generateSignature() | |||
| public function getCustomFields() | |||
| { | |||
| $fields = array_filter([ | |||
| 'Shp_TransactionId' => $this->getTransactionId(), | |||
| 'Shp_Client' => $this->getClient(), | |||
There was a problem hiding this comment.
Why did you remove Shp_Client?
There was a problem hiding this comment.
Any Shp_*is supported by RoboKassa as a custom field.
We use this field in our implementation of integration, but it's optional. It's OK if you don't fill it
|
Thank you for taking care of this package! |
|
Thank you! "require": {
"hiqdev/omnipay-robokassa": "^3.0@dev"
}, |
|
https://docs.robokassa.ru/en#2540 According to the documentation, the signature must include |
SilverFire
referenced
this pull request
Jan 11, 2019
Update PurchaseRequest.php Update PurchaseResponse.php Update CompletePurchaseResponse.php
Let's add it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.