Huge csfixing from php-cs-fixer

Removed excessive phpdoc type hinting

.php_cs

@@ -28,6 +28,7 @@ return PhpCsFixer\Config::create()
         'phpdoc_no_alias_tag'                        =>  ['replacements' => ['type' => 'var']],
         'blank_line_before_return'                   =>  false,
         'phpdoc_align'                               =>  false,
+        'phpdoc_summary'                             =>  false,
         'phpdoc_scalar'                              =>  false,
         'phpdoc_separation'                          =>  false,
         'phpdoc_to_comment'                          =>  false,

src/Exception/CannotReassignException.php

@@ -2,8 +2,8 @@
 
 namespace hiqdev\php\billing\Exception;
 
-use hiqdev\php\billing\ExceptionInterface;
 use Exception;
+use hiqdev\php\billing\ExceptionInterface;
 use Throwable;
 
 /**

src/action/AbstractAction.php

@@ -13,11 +13,11 @@
 use DateTimeImmutable;
 use hiqdev\php\billing\customer\CustomerInterface;
 use hiqdev\php\billing\EntityInterface;
+use hiqdev\php\billing\Exception\CannotReassignException;
 use hiqdev\php\billing\sale\SaleInterface;
 use hiqdev\php\billing\target\TargetInterface;
 use hiqdev\php\billing\type\TypeInterface;
 use hiqdev\php\units\QuantityInterface;
-use hiqdev\php\billing\Exception\CannotReassignException;
 
 /**
  * Chargeable Action.
@@ -56,12 +56,7 @@ abstract class AbstractAction implements ActionInterface, EntityInterface
     protected $parent;
 
     /**
-     * @param TypeInterface $type
-     * @param TargetInterface $target
-     * @param QuantityInterface $quantity
-     * @param CustomerInterface $customer
      * @param SaleInterface $sale
-     * @param DateTimeImmutable $time
      * @param ActionInterface $parent
      */
     public function __construct(

src/action/Action.php

@@ -32,8 +32,8 @@ public function isApplicable(PriceInterface $price): bool
     /**
      * // TODO: think about moving to Sale::isOccurred()
      *
-     * @return bool whether Sale that belongs to current Action occurs in current month or earlier
      * @throws \Exception
+     * @return bool whether Sale that belongs to current Action occurs in current month or earlier
      */
     private function saleOccurred(): bool
     {

src/action/ActionInterface.php

@@ -11,7 +11,6 @@
 namespace hiqdev\php\billing\action;
 
 use DateTimeImmutable;
-use hiqdev\php\billing\charge\ChargeInterface;
 use hiqdev\php\billing\customer\CustomerInterface;
 use hiqdev\php\billing\price\PriceInterface;
 use hiqdev\php\billing\sale\SaleInterface;
@@ -36,61 +35,45 @@ interface ActionInterface extends \JsonSerializable
 {
     /**
      * Returns if the given price applicable to this action.
-     *
-     * @param PriceInterface $price
-     * @return bool
      */
     public function isApplicable(PriceInterface $price): bool;
 
     /**
      * Returns client ot this action.
-     * @return CustomerInterface
      */
     public function getCustomer(): CustomerInterface;
 
     /**
      * Returns target ot this action.
-     * @return TargetInterface
      */
     public function getTarget(): TargetInterface;
 
     /**
      * Returns type ot this action.
-     * @return TypeInterface
      */
     public function getType(): TypeInterface;
 
     /**
      * Returns quantity ot this action.
-     * @return QuantityInterface
      */
     public function getQuantity(): QuantityInterface;
 
     /**
      * Returns time ot this action.
-     * @return DateTimeImmutable
      */
     public function getTime(): DateTimeImmutable;
 
     /**
      * Returns sale if set.
-     * @return SaleInterface|null
      */
     public function getSale(): ?SaleInterface;
 
     /**
      * Returns null if the action state is not set.
-     * @return bool|null
      */
     public function isFinished(): ?bool;
 
-    /**
-     * @return ActionInterface|null
-     */
     public function getParent(): ?ActionInterface;
 
-    /**
-     * @return ActionState|null
-     */
     public function getState(): ?ActionState;
 }

src/action/TemporaryAction.php

@@ -7,6 +7,7 @@
  * @license   BSD-3-Clause
  * @copyright Copyright (c) 2017-2019, HiQDev (http://hiqdev.com/)
  */
+
 namespace hiqdev\php\billing\action;
 
 use hiqdev\php\billing\customer\CustomerInterface;
@@ -27,10 +28,6 @@ class TemporaryAction extends Action implements TemporaryActionInterface
 {
     /**
      * Creates Temporary Action out of generic $action
-     *
-     * @param ActionInterface $action
-     * @param CustomerInterface $customer
-     * @return TemporaryAction
      */
     public static function createAsSubaction(ActionInterface $action, CustomerInterface $customer): TemporaryAction
     {

src/bill/Bill.php

@@ -62,15 +62,15 @@ class Bill implements BillInterface
 
     public function __construct(
                             $id,
-        TypeInterface       $type,
-        DateTimeImmutable   $time,
-        Money               $sum,
-        QuantityInterface   $quantity,
-        CustomerInterface   $customer,
-        TargetInterface     $target = null,
-        PlanInterface       $plan = null,
-        array               $charges = [],
-        BillState           $state = null
+        TypeInterface $type,
+        DateTimeImmutable $time,
+        Money $sum,
+        QuantityInterface $quantity,
+        CustomerInterface $customer,
+        TargetInterface $target = null,
+        PlanInterface $plan = null,
+        array $charges = [],
+        BillState $state = null
     ) {
         $this->id           = $id;
         $this->type         = $type;
@@ -127,17 +127,11 @@ public function setId($id)
         $this->id = $id;
     }
 
-    /**
-     * @return TypeInterface
-     */
     public function getType(): TypeInterface
     {
         return $this->type;
     }
 
-    /**
-     * @return DateTimeImmutable
-     */
     public function getTime(): DateTimeImmutable
     {
         return $this->time;
@@ -167,9 +161,6 @@ public function getQuantity()
         return $this->quantity;
     }
 
-    /**
-     * @return BillInterface
-     */
     public function setQuantity(QuantityInterface $quantity): BillInterface
     {
         $this->quantity = $quantity;
@@ -193,9 +184,6 @@ public function getPlan()
         return $this->plan;
     }
 
-    /**
-     * @return bool
-     */
     public function hasCharges(): bool
     {
         return $this->charges !== [];
@@ -211,7 +199,6 @@ public function getCharges(): array
 
     /**
      * @param ChargeInterface[] $prices
-     * @return self
      * @throws \Exception
      */
     public function setCharges(array $charges): self

src/bill/BillInterface.php

@@ -27,19 +27,10 @@
  */
 interface BillInterface extends EntityInterface
 {
-    /**
-     * @return string
-     */
     public function getUniqueString(): string;
 
-    /**
-     * @return TypeInterface
-     */
     public function getType(): TypeInterface;
 
-    /**
-     * @return DateTimeImmutable
-     */
     public function getTime(): DateTimeImmutable;
 
     /**

src/charge/Charge.php

@@ -66,13 +66,13 @@ class Charge implements ChargeInterface
 
     public function __construct(
                             $id,
-        TypeInterface       $type,
-        TargetInterface     $target,
-        ActionInterface     $action,
-        ?PriceInterface     $price,
-        QuantityInterface   $usage,
-        Money               $sum,
-        BillInterface       $bill = null
+        TypeInterface $type,
+        TargetInterface $target,
+        ActionInterface $action,
+        ?PriceInterface $price,
+        QuantityInterface $usage,
+        Money $sum,
+        BillInterface $bill = null
     ) {
         $this->id       = $id;
         $this->type     = $type;
@@ -124,9 +124,6 @@ public function getAction(): ActionInterface
         return $this->action;
     }
 
-    /**
-     * @return PriceInterface
-     */
     public function getPrice(): PriceInterface
     {
         return $this->price;
@@ -200,7 +197,7 @@ public function setComment(string $comment): ChargeInterface
 
     public function setId($id): ChargeInterface
     {
-        if ((string)$this->id === (string)$id) {
+        if ((string) $this->id === (string) $id) {
             return $this;
         }
         if ($this->id !== null) {
@@ -216,9 +213,6 @@ public function jsonSerialize()
         return array_filter(get_object_vars($this));
     }
 
-    /**
-     * @return ChargeInterface|null
-     */
     public function getParent(): ?ChargeInterface
     {
         return $this->parent;
@@ -227,8 +221,8 @@ public function getParent(): ?ChargeInterface
     /**
      * @param ChargeInterface|null $parent
      *
-     * @return Charge
      * @throws \Exception if parent is already set
+     * @return Charge
      */
     public function setParent(ChargeInterface $parent): self
     {
@@ -244,7 +238,6 @@ public function setParent(ChargeInterface $parent): self
     /**
      * Forcefully changes parent charge
      *
-     * @param ChargeInterface $parent
      * @return Charge
      */
     public function overwriteParent(ChargeInterface $parent): self

src/charge/ChargeInterface.php

@@ -27,67 +27,34 @@ interface ChargeInterface extends \JsonSerializable
      */
     public function getId();
 
-    /**
-     * @return bool
-     */
     public function hasId(): bool;
 
-    /**
-     * @return TypeInterface
-     */
     public function getType(): TypeInterface;
 
-    /**
-     * @return TargetInterface
-     */
     public function getTarget(): TargetInterface;
 
-    /**
-     * @return ActionInterface
-     */
     public function getAction(): ActionInterface;
 
-    /**
-     * @return PriceInterface
-     */
     public function getPrice(): PriceInterface;
 
-    /**
-     * @return Money
-     */
     public function getSum(): Money;
 
-    /**
-     * @return QuantityInterface
-     */
     public function getUsage(): QuantityInterface;
 
-    /**
-     * @param string $comment
-     * @return self
-     */
     public function setComment(string $comment): self;
 
     /**
      * @return string
      */
     public function getComment(): ?string;
 
-    /**
-     * @return self
-     */
     public function setFinished(): self;
 
-    /**
-     * @return ChargeInterface|null
-     */
     public function getParent(): ?ChargeInterface;
 
     /**
      * Provides unique string.
      * Can be used to compare or aggregate charges.
-     *
-     * @return string
      */
     public function getUniqueString(): string;
 }

src/charge/ChargeModifier.php

@@ -23,19 +23,13 @@ interface ChargeModifier
     /**
      * Calculates modified charges.
      *
-     * @param ChargeInterface|null $charge
-     * @param ActionInterface $action
      * @return ChargeInterface[] calculated modification charges, including the original $charge
      */
     public function modifyCharge(?ChargeInterface $charge, ActionInterface $action): array;
 
     /**
      * Returns true if modifier is applicable for the given charge
      * (due to time or other limitations).
-     *
-     * @param ChargeInterface|null $charge
-     * @param ActionInterface $action
-     * @return bool
      */
     public function isSuitable(?ChargeInterface $charge, ActionInterface $action): bool;
 }