New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http2 support #176
Http2 support #176
Conversation
packageist.org supports http2 for a few since july 2018 \o/ https://twitter.com/seldaek/status/1022179344091893760
this should be ready to land @hirak in case you have a benchmark or something like that, would be cool to run this PR thru it. |
the build errors are packagist.org infra related, not caused by the PR |
@hirak I dont have an idea why travis renderes those binary data in the logstream. do you have an idea whats happing? (I tried updating dependencies with the last commit, but this seem not to be the underlying problem) |
after making sure to only set the http2 version flag on the curl handle instead of the share/multi handles (which also make use of getCurlOptions), it seems to work now. |
ping @hirak any open issues? |
If this Pull Request is merged, does prestissimo stop working?
|
I maintain a small service related to HTTP/2 at https://http2.pro. I have an open end point described at https://http2.pro/doc/API : Any request to https://http2.pro/api/v1 will return a JSON array of that connections HTTP/2 status. I guess it will help in automated tests? Curl needs to be built with HTTP/2 or otherwise HTTP/2 support wouldn't work. Curl will fallback to HTTP/1.1 if the remote host does not support HTTP/2. In reality, it is more of "try 1.1 first, and upgrade to http/2 if possible" kind of operation. However, if HTTP/2 is not built into Curl, the constants will not be declared and will obviously throw errors. nghttp2 and Openssl versions do not matter as long as curl is built with HTTP/2. PHP itself can have a different OpenSSL version that what Curl was built with. I really think HTTP/2 support would be a good addition. |
Ping @hirak |
Ping @hirak |
adding http2 support, as packagist.org supports it now
https://twitter.com/seldaek/status/1022179344091893760
composer will use repo.packagist.org in the future for package metadata
see composer/composer@c5fa3bd