Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http2 support #176

Closed
wants to merge 15 commits into from
Closed

Http2 support #176

wants to merge 15 commits into from

Conversation

staabm
Copy link

@staabm staabm commented Jul 26, 2018

adding http2 support, as packagist.org supports it now
https://twitter.com/seldaek/status/1022179344091893760

composer will use repo.packagist.org in the future for package metadata
see composer/composer@c5fa3bd

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 81.146% when pulling 552267e on staabm:http2 into 4c52352 on hirak:master.

@coveralls
Copy link

coveralls commented Jul 26, 2018

Coverage Status

Coverage increased (+1.8%) to 81.663% when pulling ff8aa0a on staabm:http2 into 4c52352 on hirak:master.

@staabm staabm changed the title WIP Http2 Http2 support Jul 26, 2018
@staabm
Copy link
Author

staabm commented Jul 26, 2018

this should be ready to land

@hirak in case you have a benchmark or something like that, would be cool to run this PR thru it.

@staabm
Copy link
Author

staabm commented Jul 26, 2018

the build errors are packagist.org infra related, not caused by the PR

@staabm staabm closed this Jul 27, 2018
@staabm staabm reopened this Jul 27, 2018
@staabm staabm closed this Aug 3, 2018
@staabm staabm reopened this Aug 3, 2018
@staabm
Copy link
Author

staabm commented Aug 10, 2018

@hirak I dont have an idea why travis renderes those binary data in the logstream.

do you have an idea whats happing? (I tried updating dependencies with the last commit, but this seem not to be the underlying problem)

@staabm
Copy link
Author

staabm commented Aug 10, 2018

after making sure to only set the http2 version flag on the curl handle instead of the share/multi handles (which also make use of getCurlOptions), it seems to work now.

@staabm
Copy link
Author

staabm commented Aug 20, 2018

ping @hirak any open issues?

@hirak
Copy link
Owner

hirak commented Aug 21, 2018

If this Pull Request is merged, does prestissimo stop working?
I want to check the operation in various environments.

  • OpenSSL version
  • nghttp2
  • cURL version

@Ayesh
Copy link

Ayesh commented Oct 22, 2018

I maintain a small service related to HTTP/2 at https://http2.pro. I have an open end point described at https://http2.pro/doc/API : Any request to https://http2.pro/api/v1 will return a JSON array of that connections HTTP/2 status. I guess it will help in automated tests?

Curl needs to be built with HTTP/2 or otherwise HTTP/2 support wouldn't work. Curl will fallback to HTTP/1.1 if the remote host does not support HTTP/2. In reality, it is more of "try 1.1 first, and upgrade to http/2 if possible" kind of operation. However, if HTTP/2 is not built into Curl, the constants will not be declared and will obviously throw errors.

nghttp2 and Openssl versions do not matter as long as curl is built with HTTP/2. PHP itself can have a different OpenSSL version that what Curl was built with.

I really think HTTP/2 support would be a good addition.

@staabm
Copy link
Author

staabm commented Nov 6, 2018

Ping @hirak

@staabm
Copy link
Author

staabm commented Dec 24, 2018

Ping @hirak

@staabm staabm closed this Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants