Add Sort support #42
Closed
Add Sort support #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on ElastiSearch Sort, it'll add a "sort" attribute into body request.
|
@agius any news about this merge request ? |
|
@leandrocp Heya! Sorry I dropped the ball on this. Thanks so much for the PR! TBH, I thought we had implemented that during some internal customization or other, but I see that never made it here to the open source version. Looks pretty good to me - is this rebased to the ES5 version? If not, plz do, then should be merge-able this week. |
|
@agius any news about this merge request ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on ElastiSearch Sort, it'll add a "sort" attribute into body request.
I would open an Issue to discuss this feature, but the code was quick to write and a PR is better to show it working :)
Let me know if there's something wrong or missing.