Add Promise support for onComplete fn
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 57 60 +3
Branches 4 6 +2
=========================================
+ Hits 57 60 +3
Continue to review full report at Codecov.
|
|
Awesome job @edbzn ! Thanks again! ❤️ |
fixed some of the names and added a test for fakeTime to verify that async await is covered fix hirezio#1
shairez
approved these changes
Jun 13, 2020
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @edbzn for his code tests documentation and ideas |
|
I've put up a pull request to add @edbzn! 🎉 |
|
Thanks @edbzn ! you are now an official contributor as well 😄 🙏 👏 |
|
thank you @shairez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1.
I didn't updated all examples in the readme, let me know if I should.