Refactor class repository

- Add abstract class
- Add spec for abstract method

lib/active_record/sharding/abstract_repository.rb

@@ -0,0 +1,30 @@
+module ActiveRecord
+  module Sharding
+    class AbstractRepository
+
+      private
+
+        def generate_model_for_shard(connection_name)
+          base_class_name = @base_class.name
+          class_name = generate_class_name connection_name
+
+          model = Class.new(base_class) do
+            self.table_name = base_class.table_name
+
+            module_eval <<-RUBY, __FILE__, __LINE__ + 1
+                  def self.name
+                    "#{base_class_name}::#{class_name}"
+                  end
+                RUBY
+          end
+
+          model.class_eval { establish_connection(connection_name) }
+          model
+        end
+
+        def generate_class_name(connection_name)
+          raise NotImplementedError.new("#{self.class.name}.#{__method__} is an abstract method.")
+        end
+    end
+  end
+end

lib/active_record/sharding/sequencer_repository.rb

@@ -1,6 +1,6 @@
 module ActiveRecord
   module Sharding
-    class SequencerRepository
+    class SequencerRepository < AbstractRepository
       attr_reader :base_class
 
       def initialize(sequencer_config, base_class)
@@ -14,24 +14,6 @@ def fetch(connection_name)
 
       private
 
-      def generate_model_for_shard(connection_name)
-        base_class_name = @base_class.name
-        class_name = generate_class_name connection_name
-
-        model = Class.new(base_class) do
-          self.table_name = base_class.table_name
-
-          module_eval <<-RUBY, __FILE__, __LINE__ + 1
-                  def self.name
-                    "#{base_class_name}::#{class_name}"
-                  end
-                RUBY
-        end
-
-        model.class_eval { establish_connection(connection_name) }
-        model
-      end
-
       def generate_class_name(connection_name)
         "SequencerFor#{connection_name.to_s.tr('-', '_').classify}"
       end

lib/active_record/sharding/shard_repository.rb

@@ -1,6 +1,6 @@
 module ActiveRecord
   module Sharding
-    class ShardRepository
+    class ShardRepository < AbstractRepository
       attr_reader :base_class
 
       def initialize(cluster_config, base_class)
@@ -23,24 +23,6 @@ def all
 
       private
 
-      def generate_model_for_shard(connection_name)
-        base_class_name = @base_class.name
-        class_name = generate_class_name connection_name
-
-        model = Class.new(base_class) do
-          self.table_name = base_class.table_name
-
-          module_eval <<-RUBY, __FILE__, __LINE__ + 1
-                  def self.name
-                    "#{base_class_name}::#{class_name}"
-                  end
-                RUBY
-        end
-
-        model.class_eval { establish_connection(connection_name) }
-        model
-      end
-
       def generate_class_name(connection_name)
         "ShardFor#{connection_name.to_s.tr('-', '_').classify}"
       end

lib/activerecord-sharding.rb

@@ -5,6 +5,7 @@
 require "active_record/sharding/config"
 require "active_record/sharding/cluster_config"
 require "active_record/sharding/modulo_router"
+require "active_record/sharding/abstract_repository"
 require "active_record/sharding/shard_repository"
 require "active_record/sharding/database_tasks"
 require "active_record/sharding/model"

spec/active_record/sharding/abstract_repository_spec.rb

@@ -0,0 +1,15 @@
+describe ActiveRecord::Sharding::AbstractRepository do
+  describe "#generate_class_name" do
+    let!(:repository) do
+      Class.new(ActiveRecord::Sharding::AbstractRepository) do
+        def initialize
+          generate_class_name "test"
+        end
+      end
+    end
+
+    it "raise NotImplementedError" do
+      expect { repository.new }.to raise_error NotImplementedError
+    end
+  end
+end