Initiator members public #85
Open
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <avi@deitcher.net>
|
Hi @hirochachacha what can I do to help move this along? |
|
Probably wont change after almost a year of your first Issue to that topic: @hirochachacha I would also really like to have anonymous support and when an interface is provided, it should be injectable. So plus one on this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The members of the
Initiator interfaceare private. That makes it impossible to plug in other initiators that might have additional capabilities (e.g., see the one that supports anonymous auth here from #29 ).This PR changes those to public, so that you can plug others ones in. It also changes the one implementation,
NTLMInitiator, to use public methods so it implements the modified interface. Finally, it changes the one place (spnego.go) that references it to use the modified interface members.This does not change the
go-smb2functionality at all, but does make it more pluggable.