Skip to content

Commit

Permalink
fix(fusuma): allow undefined for gzSize
Browse files Browse the repository at this point in the history
  • Loading branch information
hiroppy committed Mar 5, 2021
1 parent 9ef7beb commit 80386cd
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
10 changes: 4 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,13 +197,11 @@ You can see your Note for each slide and the next slide on the Host screen.

> [Lighthouse](https://developers.google.com/web/tools/lighthouse) is an open-source, automated tool for improving the quality of web pages. You can run it against any web page, public or requiring authentication. It has audits for performance, accessibility, progressive web apps, SEO and more.
Fusuma supports improving performance, SEO, and so on as default.
Fusuma supports improving performance, SEO, and so on as default, analyzes the slide's performance, and outputs like below.

<img src="./site/docs/assets/lighthouse.png" width="500px">

Fusuma analyzes the slide's performance, and outputs like below.

<img src="./output-logs.png" width="500px">
| the score of lighthouse | output logs |
| :------------------------------------: | :--------------------: |
| ![](./site/docs/assets/lighthouse.png) | ![](./output-logs.png) |

---

Expand Down
Binary file modified output-logs.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/fusuma/src/utils/buildLogs.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ function buildLogs(logs) {
isAsync ? asyncChunk : syncChunk
} ${name}`,
chalk.blue(prettyBytes(size)),
gzSize !== 0 ? chalk.blue(prettyBytes(gzSize)) : '',
gzSize ? chalk.blue(prettyBytes(gzSize)) : '',
]);
});

Expand Down
Binary file modified site/docs/assets/lighthouse.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 80386cd

Please sign in to comment.