Add dataset sub-command
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2020 07:15
|
Is (if this is meta data cache file, perhaps its name should be listed in .gitignore) |
|
We really appreciate it if sample |
Thanks! This is my mistake and removed! |
added 2 commits
August 3, 2020 09:27
snowhork
reviewed
Aug 3, 2020
cmd/cache.go
Outdated
| if err != nil { | ||
| fmt.Println("Failed to fetch cache: %s", err) | ||
| } | ||
| fmt.Println("dataset meta data are cached to %s", config.CacheFile) |
snowhork
reviewed
Aug 3, 2020
cmd/cache.go
Outdated
| } | ||
| err := metas.Save(config.CacheFile) | ||
| if err != nil { | ||
| fmt.Println("Failed to fetch cache: %s", err) |
There was a problem hiding this comment.
You mean Faile to save cache ?
and, need to return ?
Is this message below correct?
$ ./bqiam cache
Failed to fetch cache: %s Failed to save meta data cache file. err: open ~/.bqiam-cache-file.toml: no such file or directory
dataset meta data are cached to %s ~/.bqiam-cache-file.toml
There was a problem hiding this comment.
You're right! I fixed this implementation. Please check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented
datasetsubcommand that extracts permissions of the input user for each dataset.usage: