implement cache auto refresh #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2020 19:11
snowhork
reviewed
Aug 9, 2020
|
@hirosassa LGTM! thanks! |
hirosassa
added a commit
that referenced
this pull request
Aug 24, 2020
…functionalities (#11) * add grantBQJobUser and permit project wide permissions * Update README.md * implement cache auto refresh (#10) * implement cache auto refresh * fix typo * fix * change to cacherefreshhour Co-authored-by: hirohito-sasakawa <hirohito-sasakawa@m3.com> * fix bug on cache refresh flag (#15) * fix bug on cache refresh flag * remove Co-authored-by: hirohito-sasakawa <hirohito-sasakawa@m3.com> * add grantBQJobUser and permit project wide permissions * refactor * fix package * import order * lint * fix match member * refactor * fix package * import order * lint * fix match member * fix * edit readme * fix typo * support service account Co-authored-by: hirohito-sasakawa <hirohito-sasakawa@m3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2
What is this PR
This PR added cache refresh functionality that check if the cache file is new enough and refresh if it is expired and the user confirmed.