Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add permit command #9

Merged
merged 5 commits into from
Aug 8, 2020
Merged

Conversation

snowhork
Copy link
Contributor

@snowhork snowhork commented Aug 7, 2020

This pr is for permit command.

To permit some user(s) to some dataset(s) access as READER or WRITER or OWNER.

@snowhork
Copy link
Contributor Author

snowhork commented Aug 7, 2020

@hirosassa
Hi, this PR is draft.

I'll fix lint and implement "Ask and Confirm" soon.

Please review.

@hirosassa
Copy link
Owner

hirosassa commented Aug 7, 2020

@snowhork Thanks!! I think this functionality is GREATLY needed for BQ admin(s).

Please check CI comments for some formatting issues.

cmd/permit.go Outdated Show resolved Hide resolved
cmd/permit.go Outdated Show resolved Hide resolved
cmd/permit.go Outdated Show resolved Hide resolved
@hirosassa
Copy link
Owner

Please add description for this functionality on README

@snowhork
Copy link
Contributor Author

snowhork commented Aug 8, 2020

@hirosassa I've fixed!

@hirosassa
Copy link
Owner

hirosassa commented Aug 8, 2020

@snowhork Thanks! Looks this PR ready to be merged

@hirosassa hirosassa merged commit e78638e into hirosassa:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants