fix: limit scope of stacks_rw_db usage to free lock #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
temporarily deployed
to
Development-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-testnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-testnet
GitHub Actions
Inactive
MicaiahReid
force-pushed
the
fix-db-reingest
branch
from
42b93d2
to
5d15171
Compare
MicaiahReid
temporarily deployed
to
Development-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-testnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-testnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-testnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-testnet
GitHub Actions
Inactive
csgui
reviewed
Apr 2, 2024
csgui
reviewed
Apr 2, 2024
csgui
reviewed
Apr 2, 2024
csgui
reviewed
Apr 2, 2024
csgui
requested changes
Apr 2, 2024
There was a problem hiding this comment.
At first, I thought the code could be simplified. However, upon closer inspection, I noticed that the data struct differs between StacksChainEvent::ChainUpdatedWithBlocks and StacksChainEvent::ChainUpdatedWithReorg. As a result, a more effective code reorganization is possible, but it would require deeper changes that are beyond the scope of this pull request.
Code LGTM, just a small change on the error message.
csgui
approved these changes
Apr 2, 2024
MicaiahReid
had a problem deploying
to
Development-mainnet
GitHub Actions
Failure
MicaiahReid
had a problem deploying
to
Development-testnet
GitHub Actions
Failure
MicaiahReid
added a commit
that referenced
this pull request
Apr 2, 2024
Every 32 stacks blocks, Chainhook attempts to check for a new archive file to fix any potential holes in the database. This process requires readwrite access to the stacks.rocksdb. However, the process that called this subprocess already had a readwrite instance of the database open, which was preventing the lock from being cleared. This PR sets the scope of the initial usage of the db in order to free up the lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every 32 stacks blocks, Chainhook attempts to check for a new archive file to fix any potential holes in the database. This process requires readwrite access to the stacks.rocksdb. However, the process that called this subprocess already had a readwrite instance of the database open, which was preventing the lock from being cleared.
This PR sets the scope of the initial usage of the db in order to free up the lock.
Fixes #518