New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loading of illustration in connection modal #173
Comments
We are trying to modify the photo on this modal, but we didn't find any documentation is there anyway of doing this? |
This is an illustration specific to the Hiro Wallet. No, it can't be changed unless you fork this repo. It is not something we support/document. |
@nokhodian Do you want to change the illustration itself or the app icon to the bottom-right corner of the illustration? IllustrationApp iconIf the app icon, you can pass the URL for it during authentication with Connect. |
@fbwoolf what remains to standardize these days with the intro modal here? Should we keep this issue open and modify it to capture the remaining work more specifically, or close out? |
The problem was that no image was showing up and we couldn't modify the path, the only solution was statically putting the image where it was hardcoded, we ended up implementing the whole modal at our side though :) |
Sorry I'm still not clear on which image wasn't showing up exactly. Do you mean the app icon or illustration or both?
Did you fork the library or create a new custom modal out of curiosity? |
Thanks for the screenshot for clarification 🙏 If you right click on the broken image, can you copy and paste the URL that's attempted for loading here? |
@markmhx this is outdated. The illustration in Connect has been updated and no longer includes the app icon. |
sure,,,, /assets/download-hiro-wallet.png ... that's the image and if you statically put an image there it will show up, however, we didn't want to compromise on the structure of our project. |
Thanks! By "we didn't want to compromise on the structure of our project", what do you mean exactly? |
we didn't want to add a folder and file exactly like its defined, we have another folder for static resources |
I feel like this was reported as a separate bug regarding the app icon, but now there is a different bug with the png being used for the new illustration. Just wanting to make note of that bc when this issue was created in October |
Nvm, I read back through the thread here. I see the thread is a bit confusing ...but this is def a bug with the new png illustration, so I'll fix it. |
@markmhx is this something I should take on today and get fixed? |
There seem to be a few open issues in stenciljs regarding the |
I'm not super familiar with this problem, but indeed these issues look very stale. I would try either:
|
The text was updated successfully, but these errors were encountered: