Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict FT/NFT metadata flag #1007

Closed
rafaelcr opened this issue Jan 26, 2022 · 2 comments · Fixed by #1165
Closed

Add strict FT/NFT metadata flag #1007

rafaelcr opened this issue Jan 26, 2022 · 2 comments · Fixed by #1165
Assignees
Labels
P2 Priority 2 Critical functionality not working Impacts one/few customers

Comments

@rafaelcr
Copy link
Collaborator

We currently have flags that enable FT/NFT metadata processing in .env, but this does not guarantee the metadata is available when required.
We should add another flag that toggles a strict mode (STACKS_API_METADATA_STRICT_MODE) that, when enabled, it will try again forever if the metadata retrieval error is recoverable. If it's not, then try a given number of times before failing.

Relevant codepaths:


@rafaelcr rafaelcr added the tt label Jan 27, 2022
@saralab saralab added the P3 Priority 3 There are workarounds, or the functionality is secondary label Feb 8, 2022
@MHassanTariq
Copy link
Contributor

@rafaelcr can you tell me how can I reproduce this error? And how to check if the metadata retrieval error is recoverable?

@rafaelcr
Copy link
Collaborator Author

When I filed this issue we didn't have a specific error in mind. Recoverable errors would be timeouts, parsing errors, etc. that could be affected by network performance or some other code paths. Critical errors would be 500 error codes and things like that. @MHassanTariq

@MHassanTariq MHassanTariq linked a pull request Mar 29, 2022 that will close this issue
9 tasks
@zone117x zone117x added P2 Priority 2 Critical functionality not working Impacts one/few customers and removed P3 Priority 3 There are workarounds, or the functionality is secondary labels Apr 7, 2022
@zone117x zone117x assigned rafaelcr and unassigned MHassanTariq May 10, 2022
@zone117x zone117x removed the tt label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority 2 Critical functionality not working Impacts one/few customers
Projects
Archived in project
5 participants