Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nakamoto] Support pox-4 changes #1735

Closed
zone117x opened this issue Oct 4, 2023 · 4 comments · Fixed by #1829
Closed

[Nakamoto] Support pox-4 changes #1735

zone117x opened this issue Oct 4, 2023 · 4 comments · Fixed by #1829
Assignees

Comments

@zone117x
Copy link
Member

zone117x commented Oct 4, 2023

Some PoX contract functions (and events) will likely be updated with new fields as described at: https://github.com/stacksgov/sips/blob/feat/sip-021-nakamoto/sips/sip-021/sip-021-nakamoto.md#changes-to-pox

The changes aren't fully defined yet. This issue is tracking them:
stacks-network/stacks-core#3948

There will likely be new arguments/fields added to the PoX contract functions that the API is currently parsing and storing. If so, the API can ingest and expose these for the pox/stacking related endpoints.

@zone117x
Copy link
Member Author

zone117x commented Oct 4, 2023

There are also likely changes needed for the Rosetta layer, e.g. when creating stacking transactions via Rosetta. TBD..

@zone117x
Copy link
Member Author

zone117x commented Dec 11, 2023

Pox-4 support implemented and tested in #1754 and #1762

The pox-4 contract doesn't yet include signer arguments for the stacking functions described in SIP-021, that functionality is planned for the Argon milestone, and is being tracked here: stacks-network/stacks-core#3970

@zone117x
Copy link
Member Author

zone117x commented Jan 2, 2024

The signer-key argument is being added to pox-4.clar functions in stacks-network/stacks-core#4209 (not yet merged)

@zone117x
Copy link
Member Author

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants