Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multisig support to contract deploys #1539

Merged

Conversation

fess-v
Copy link
Contributor

@fess-v fess-v commented Aug 4, 2023

Description

Contract deploy transactions had no possibility to be sent from a multisig address.

Breaking change?

This is not a breaking change, just makes deploy transactions work the same way as makeContractCall and makeSTXTokenTransfer.

Example

It is now possible to pass publicKeys and numSignatures parameters to deploy any contract from a multisig.

const tx = await makeContractDeploy({
    codeBody,
    contractName,
    publicKeys: pubKeyStrings,
    numSignatures: 3,
    signerKeys: privKeyStrings,
    fee,
    nonce,
    network: new StacksTestnet(),
    anchorMode: AnchorMode.Any,
  });

Checklist

@vercel
Copy link

vercel bot commented Aug 4, 2023

@fess-v is attempting to deploy a commit to the Hiro Systems Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

@janniks janniks self-requested a review August 4, 2023 15:57
@smcclellan smcclellan added this to the Q3-2023 milestone Aug 14, 2023
@janniks janniks changed the title Feat/multisig support contract deploy feat: add multisig support to contract deploys Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1539 (2ba96ca) into main (761923d) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 80.48%.

@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
- Coverage   66.19%   66.16%   -0.03%     
==========================================
  Files         118      118              
  Lines        8638     8637       -1     
  Branches     1907     1910       +3     
==========================================
- Hits         5718     5715       -3     
- Misses       2793     2795       +2     
  Partials      127      127              
Files Changed Coverage Δ
packages/auth/src/protocolEchoDetection.ts 11.42% <0.00%> (-0.34%) ⬇️
packages/auth/src/userSession.ts 54.54% <ø> (ø)
packages/cli/src/cli.ts 31.59% <0.00%> (ø)
packages/cli/src/common.ts 64.28% <ø> (ø)
packages/cli/src/encrypt.ts 83.33% <ø> (ø)
packages/cli/src/network.ts 28.96% <ø> (ø)
packages/common/src/errors.ts 31.62% <ø> (ø)
packages/storage/src/hub.ts 84.76% <ø> (ø)
packages/transactions/src/cl.ts 100.00% <ø> (ø)
packages/transactions/src/builders.ts 78.07% <92.30%> (+0.46%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

@janniks janniks merged commit 260f2d5 into hirosystems:main Sep 4, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants