Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add stacks transaction memo equality by removing trailing empty … #1630

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Feb 19, 2024

This PR was published to npm with the version 6.11.4-pr.0cd4885.0
e.g. npm install @stacks/common@6.11.4-pr.0cd4885.0 --save-exact

thx for the find @jbencin πŸ™

@janniks janniks requested a review from jbencin February 19, 2024 15:36
Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
stacksjs-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 20, 2024 4:45pm

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (922e037) 66.37% compared to head (85fbfb0) 66.39%.

❗ Current head 85fbfb0 differs from pull request most recent head 0cd4885. Consider uploading reports for the commit 0cd4885 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
+ Coverage   66.37%   66.39%   +0.01%     
==========================================
  Files         119      119              
  Lines        8717     8718       +1     
  Branches     1920     1920              
==========================================
+ Hits         5786     5788       +2     
+ Misses       2806     2805       -1     
  Partials      125      125              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@janniks janniks merged commit bb0b85d into main Feb 29, 2024
9 checks passed
@janniks janniks deleted the fix/trim-empty-trail-memo branch February 29, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

Transaction not identical after serialize/deserialize
3 participants