Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@stacks/auth not usable in app #852

Closed
friedger opened this issue Nov 9, 2020 · 7 comments
Closed

@stacks/auth not usable in app #852

friedger opened this issue Nov 9, 2020 · 7 comments
Assignees

Comments

@friedger
Copy link
Collaborator

friedger commented Nov 9, 2020

Describe the bug
Importing @stacks/auth 1.0.0-beta.9 results in the error using a simple react app

Failed to compile.

./node_modules/@stacks/connect/dist/connect.esm.js
Module not found: Can't resolve 'blockstack' in '/home/friedger/_repos/github/friedger/speed-spend/node_modules/@stacks/connect/dist'

What version of stacks.js are you using?
1.0.0-beta.9
Is the bug present in the Blockstack CLI, Gaia hub, Connect or Blockstack Browser?
auth

To Reproduce
Steps to reproduce the behavior:

  1. git checkout speed spend
  2. update dependencies to stacks/auth
  3. yarn start
  4. See error

Expected behavior
Just resolve the dependencies

Additional context
@stacks/auth (exports useConnect) uses @stacks/connect (exports useConenct, imports UserSession) uses @stacks/auth (exports UserSession)

@friedger
Copy link
Collaborator Author

friedger commented Nov 9, 2020

Adding blockstack as a dependency helps as a workaround.

@alexkeating
Copy link
Contributor

I think this was resolved with #875

@pradel
Copy link
Contributor

pradel commented Jan 4, 2021

Same error with v1.0.0-beta.20 I think it was not resolved.

@markmhendrickson
Copy link

@pradel @friedger Is this still a problem if you import stacks/connect instead of stacks/auth, and does the former work for your purposes?

@pradel
Copy link
Contributor

pradel commented Jan 5, 2021

@markmhx I think this (stale) pr needs to be merged first to get rid of this issue leather-wallet/extension#686

@markmhendrickson
Copy link

markmhendrickson commented Jan 7, 2021

Sounds good. This is now blocked by the new PR leather-wallet/extension#743

I'm assigning this issue to @hstove so he follows up here after that PR is merged.

@markmhendrickson
Copy link

This will go live with leather-wallet/extension#761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants