Begin making the code generic for any kind of stream. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is still more that can be done, but my knowledge of Modbus isn't extensive. For instance, MODBUS_PROTOCOL_TCP is hardcoded, and I assume that a complete generic implementation must provide a way to abstract that, too. I've also made the API object-oriented by turning functions like `read_coils` into methods on `Context`.
|
I'm closing this, but development in the trait-based direction is going on.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still more that can be done, but my knowledge of Modbus isn't extensive. For instance, MODBUS_PROTOCOL_TCP is hardcoded, and I assume that a complete generic implementation must provide a way to abstract that, too.
I've also made the API object-oriented by turning functions like
read_coilsinto methods onContext.Note that I don't think these changes should be pulled immediately; this is more of a request for suggestions on how make the API more reusable.