Upgrade Flutter and fix Android typing to align with the SDK #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump Flutter to 3.3.8
chuganzy
force-pushed
the
upgrade-flutter
branch
from
46f6310
to
e5566cb
Compare
chuganzy
commented
Nov 24, 2022
| ]); | ||
| expect( | ||
| context.pageFinishedEvents, | ||
| anyOf(isEmpty, [ |
There was a problem hiding this comment.
onPageFinished in this case is no longer called on Android 13.
chuganzy
commented
Nov 24, 2022
| @@ -1,12 +1,12 @@ | |||
| buildscript { | |||
| ext.kotlin_version = '1.3.50' | |||
| ext.kotlin_version = '1.5.31' | |||
There was a problem hiding this comment.
Flutter's minimum Kotlin version.
chuganzy
commented
Nov 24, 2022
| @@ -5,6 +5,8 @@ import 'package:flutter_test/flutter_test.dart' as test; | |||
| import 'package:native_webview/native_webview.dart'; | |||
| import 'package:native_webview_example/integration_test/webview_event.dart'; | |||
|
|
|||
| const TARGET_URL = "https://example.com/"; | |||
There was a problem hiding this comment.
Switched from dart.dev to example.com because dart.dev has some videos embedded, which require user's interaction to load, and result in a navigation error.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make this package compatible with Flutter 3.3.x.
No change was needed in iOS, but some were needed in Android for nullability updates in Flutter SDK.
This PR also improves Android integration test's stability.