Resolve #43

[shahabganji]

When building the configuration an absolute path should be provided.

[hishamco]

If you can create a functional test for LocalizationSample.Mvc I will merge this soon, otherwise see my comments and I will add the functional test after

[hishamco]

I will add some commits to yours if you don't mind

[hishamco]

@shahabganji are you sure both of functional tests are passed?

[shahabganji]

@hishamco , yes pretty much sure

[hishamco]

Strange!! It doesn't work with me ;)

[hishamco]

Let me check what's prevent the test with French culture ...

[shahabganji]

Would you try dotnet test via the command line?

[hishamco]

Sure, but it should be similar ;)

[hishamco]

Same thing, let me try something, coz the issue in the application root path

[hishamco]

Finally it got work!! I will update the PR soon, @shahabganji please check it again in your end

[shahabganji]

ping me whenever you've updated the PR, I will check it too. What was the cause of the problem ?

[hishamco]

@shahabganji as I said earlier the issue comes from the application root path, please pull and test your functional tests with my latest changes

Also revert unnecessary changes in the samples files

[hishamco]

There 're two failing tests I need to fix after this PR, please run your added functional tests and revert the unnecessary changes

I will merge this when you confirm

[hishamco]

LGTM, just waiting for your confirm if the functional tests are passed

[shahabganji]

LGTM, all passed. well done 👍

[hishamco]

Thank you very much Saeed

[shahabganji]

My pleasure Hisham 👍 Please push a nuget package 🙏

[hishamco]

FYI @shahabganji https://github.com/hishamco/My.Extensions.Localization.Json/releases/tag/v2.1, the NuGet package will be show up soon https://www.nuget.org/packages/My.Extensions.Localization.Json/2.1.0

[shahabganji]

Great! Thanks.

…

Am 08.04.2020 um 02:14 schrieb Hisham Bin Ateya ***@***.***>:  FYI @shahabganji https://github.com/hishamco/My.Extensions.Localization.Json/releases/tag/v2.1, the NuGet package will be show up soon ... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.