Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bin-script known issue to readme #21

Closed
wants to merge 2 commits into from
Closed

Conversation

Tieske
Copy link
Contributor

@Tieske Tieske commented May 28, 2018

No description provided.

@coveralls
Copy link

coveralls commented May 28, 2018

Coverage Status

Coverage decreased (-4.4%) to 83.254% when pulling b06b99c on Tieske:master into be9319d on hishamhm:master.

@Tieske
Copy link
Contributor Author

Tieske commented May 29, 2018

Since coverage decreased by updating the readme (?), I had a look at the test configuration and updated that as well, to include only the actual datafile code and nothing else.

@hishamhm
Copy link
Owner

hishamhm commented Jun 5, 2018

Oh, this is a nasty limitation. I'm not even sure I was aware of it. I'd rather try to think a way to fix it rather than just documenting it.

I'll give this some thought. At first glance it doesn't sound like something fully fixable in pure Lua, but we might do some heuristics like using arg[0] and maybe OS-specific environment variables.

@Tieske
Copy link
Contributor Author

Tieske commented Jun 5, 2018

You cannot fix it. Because multiple rocks might write the same script in the bin directory (overwriting each other, which is another problem, but that is what it is because it is in the system path). And because of that, it cannot be fixed.

By the way: the description is a bit elaborate. A shorter version would be to move the commandline script in a module. And add a bootstrap-script in bin that loads and executes the module.

@hishamhm
Copy link
Owner

hishamhm commented Jun 5, 2018

@Tieske if we're dealing with a LuaRocks-installed bin script, the luarocks-aware datafile loader should be able to cheat and ask the LuaRocks loader about it.

I'll try hacking something together.

@Tieske
Copy link
Contributor Author

Tieske commented Oct 15, 2018

ping @hishamhm

@hishamhm
Copy link
Owner

@Tieske I could not reproduce this. When I run cd test; luarocks install test-datafile-scm-1.rocksec and then I run the installed test_script, it works.

BTW, I just pushed release 0.6 with a fix for LR3.

@hishamhm
Copy link
Owner

I'm closing this for now -- if the problem persists, let's reopen and discuss.

@hishamhm hishamhm closed this Oct 15, 2018
@Tieske
Copy link
Contributor Author

Tieske commented Oct 25, 2018

@hishamhm can you merge the .luacov config file anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants