Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate dark mode flickering #46

Closed
hugoattal opened this issue Mar 16, 2022 · 2 comments
Closed

Investigate dark mode flickering #46

hugoattal opened this issue Mar 16, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@hugoattal
Copy link
Collaborator

hugoattal commented Mar 16, 2022 •
edited
Loading

There's sometimes a disturbing flickering with white/dark mode...

Maybe it's linked to vueuse? (Pinia documentation had the same problem: vuejs/pinia#686)

Doing this "conveniently" make it work 😐 ...

// util/dark.ts
export const toggleDark_ = useToggle(isDark)

export const toggleDark = () => {
  toggleDark_()
  console.trace()
}
@hugoattal hugoattal added the bug Something isn't working label Mar 16, 2022
@Akryum
Copy link
Member

Akryum commented Mar 16, 2022

vueuse/vueuse#808

@Akryum Akryum closed this as completed Mar 16, 2022
@Akryum
Copy link
Member

Akryum commented Mar 16, 2022

Fixed in 8f99248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Akryum @hugoattal