Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sveltekit): update SvelteKit example #281

Closed
wants to merge 6 commits into from

Conversation

oekazuma
Copy link

@oekazuma oekazuma commented Sep 7, 2022

Description

  • Updated SvelteKit example
  • Added Tailwind CSS example for SvelteKit

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for histoire-examples-vue3 failed.

Name Link
🔨 Latest commit 34b001c
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/632918a32ac976000987d6e3

@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit 34b001c
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/632918a393d5ae0009a869c1

@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for histoire-examples-svelte3 failed.

Name Link
🔨 Latest commit 34b001c
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/632918a31ae08600086731c7

@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 34b001c
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/632918a3ad64fe00082b7438
😎 Deploy Preview https://deploy-preview-281--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tkreek
Copy link

tkreek commented Sep 19, 2022

Were you able to get tailwinds working in this demo? For me, Taiwinds gets imported in the design system tab but none of the svelte components render with it.

@oekazuma
Copy link
Author

Hmmm... It may not work well. I will close and resubmit this PR once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants