Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Controls refacto + add number and textarea (fix #30) #55

Merged
merged 15 commits into from Mar 20, 2022

Conversation

hugoattal
Copy link
Collaborator

@hugoattal hugoattal commented Mar 18, 2022

Linked to #30

Description

I added HstNumber and HstTextarea and made a few changes, tell me if there's something bothering you...

  • I removed the slot and use a title property for controls
    • I don't see a good usage of slot instead of title, what would the user do with it beyond just putting some text?
    • I think it's easier to provide a title attribute so that overflowed valued can be read on hover
  • I changed HstInput to HstText and remove the attributes handling
    • I think giving a straight input isn't very helpful to the end-user.
    • For example, we can't provide cool features for specific types (like numbers for example)
    • I think we should give ready-to-use controls instead and HstText give a good hint of what kind of data is expected
  • I added HstWrapper to get a coherent design between controls
    • I added a reverse property for the specific usage inside Histoire (for Rotate or Checkerboard tooltips)
  • It's not linked to this issue, but I added a way to specify percentages for grid layout variant (I thought it was useful to get a vertical list by settings the width to 100%)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@netlify
Copy link

netlify bot commented Mar 18, 2022

✅ Deploy Preview for histoire-site ready!

🔨 Explore the source changes: e9c9dfc

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoire-site/deploys/623747ca1e9e280009764762

😎 Browse the preview: https://deploy-preview-55--histoire-site.netlify.app

@netlify
Copy link

netlify bot commented Mar 18, 2022

✅ Deploy Preview for histoire-examples-vue3 ready!

🔨 Explore the source changes: e9c9dfc

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoire-examples-vue3/deploys/623747ca0356540009562524

😎 Browse the preview: https://deploy-preview-55--histoire-examples-vue3.netlify.app

@netlify
Copy link

netlify bot commented Mar 18, 2022

✅ Deploy Preview for histoire-controls ready!

🔨 Explore the source changes: e9c9dfc

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoire-controls/deploys/623747ca0d9c1c000955709f

😎 Browse the preview: https://deploy-preview-55--histoire-controls.netlify.app

@hugoattal hugoattal self-assigned this Mar 18, 2022
@hugoattal hugoattal added enhancement New feature or request and removed draft labels Mar 18, 2022
@hugoattal hugoattal requested a review from Akryum March 18, 2022 23:06
@Akryum Akryum merged commit 96fd481 into main Mar 20, 2022
@Akryum Akryum deleted the more-controls branch March 20, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants