Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiles extraction with check_tissue=False is performed within the tissue box #107

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Tiles extraction with check_tissue=False is performed within the tissue box #107

merged 2 commits into from
Jun 23, 2020

Conversation

alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Jun 23, 2020 •
edited
Loading

Even with check_tissue=False, the tiles will be extracted within the tissue box
Fix #100

Fix bug with the number of tiles returned from the random tiler (one more than expected)
Fix #108

@alessiamarcolini alessiamarcolini added this to In progress in histolab via automation Jun 23, 2020
@alessiamarcolini alessiamarcolini moved this from In progress to Done in histolab Jun 23, 2020
nicolebussola
nicolebussola approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@nicolebussola nicolebussola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nicolebussola
nicolebussola approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@nicolebussola nicolebussola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolebussola nicolebussola merged commit 42b1625 into master Jun 23, 2020
@nicolebussola nicolebussola deleted the fix-box-check_tissue-false branch June 23, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolebussola nicolebussola nicolebussola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
histolab
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random Tiler returns one tile more than expected RandomTiler raise ValueError with check_tissue=False
2 participants
@alessiamarcolini @nicolebussola