Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SlideSet iterable #177

Merged
merged 4 commits into from Nov 22, 2020
Merged

Make SlideSet iterable #177

merged 4 commits into from Nov 22, 2020

Conversation

ernestoarbitrio
Copy link
Member

No description provided.

@ernestoarbitrio ernestoarbitrio linked an issue Nov 16, 2020 that may be closed by this pull request
SlideSet can be an iterable #170
Closed
@ernestoarbitrio ernestoarbitrio added this to In progress in histolab via automation Nov 16, 2020
@coveralls
Copy link

coveralls commented Nov 16, 2020 •
edited

Coverage Status

Coverage decreased (-0.06%) to 97.478% when pulling d03282a on iterable-slideset-issue170 into 2f72c50 on master.

alessiamarcolini
alessiamarcolini reviewed Nov 16, 2020
View reviewed changes
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give this PR a name, we can link the issue number in the description

src/histolab/slide.py Outdated Show resolved Hide resolved
src/histolab/slide.py Show resolved Hide resolved
@ernestoarbitrio ernestoarbitrio changed the title Fixes https://github.com/histolab/histolab/issues/170 Make SlideSet iterable Nov 21, 2020
alessiamarcolini
alessiamarcolini approved these changes Nov 21, 2020
View reviewed changes
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestoarbitrio ernestoarbitrio merged commit 2e90a45 into master Nov 22, 2020
histolab automation moved this from In progress to Done Nov 22, 2020
@ernestoarbitrio ernestoarbitrio deleted the iterable-slideset-issue170 branch November 22, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessiamarcolini alessiamarcolini alessiamarcolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
histolab
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SlideSet can be an iterable
3 participants
@ernestoarbitrio @coveralls @alessiamarcolini