Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quickstart with the tile locator, add locator for all scorer and fix negative levels #212

Merged
merged 14 commits into from
Jan 18, 2021

Conversation

nicolebussola
Copy link
Collaborator

Resolve issue 207

@coveralls
Copy link

coveralls commented Jan 8, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling e481035 on quick_start into 0a5c448 on master.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do the same adjustment suggested in the readme also in the quickstart.rst. Furthermore i'd like to mention the possibility to use the locate tiles even in the ScoreTiler, justo to inform that this method is available for each scorer in histolab

@alessiamarcolini alessiamarcolini linked an issue Jan 10, 2021 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
@nicolebussola nicolebussola linked an issue Jan 11, 2021 that may be closed by this pull request
@nicolebussola nicolebussola changed the title update quickstart with the tile locator update quickstart with the tile locator, add custom locator for the ScoreTiler and fix negative levels Jan 11, 2021
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolebussola nicolebussola changed the title update quickstart with the tile locator, add custom locator for the ScoreTiler and fix negative levels update quickstart with the tile locator, add locator for all scorer and fix negative levels Jan 13, 2021
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see why to generate the tiles and the scores twice (if we save the report) by getting the scores and the scaled scores separately. I guess we are duplicating the execution time because we are calling self._tiles_generator(slide) twice.
We could @lru_cache the method _tiles_generator so with different slide parameter the result is recalculated.... but I'm not sure, @ernestoarbitrio what do you think?

.github/workflows/tests.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/histolab/tiler.py Outdated Show resolved Hide resolved
src/histolab/tiler.py Outdated Show resolved Hide resolved
@ernestoarbitrio
Copy link
Member

I can't see why to generate the tiles and the scores twice (if we save the report) by getting the scores and the scaled scores separately. I guess we are duplicating the execution time because we are calling self._tiles_generator(slide) twice.
We could @lru_cache the method _tiles_generator so with different slide parameter the result is recalculated.... but I'm not sure, @ernestoarbitrio what do you think?

The problem here is that for the locate tiles (scorer) we can't have a method that returns 2 values, otherwise we cannot generalize that method. The idea of just parametrizing with the scored(bool) was just a POC for having some workable and usable thing. Myabe this can be refactored in a separate PR ... i can take care of it ... lmk what you think. If you agree just merge this and re-open a new issue and assign it to me :D

Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ernestoarbitrio alright, approving this and opening a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative levels are note well computed in Tiler Update Quick start with the tile locator
4 participants