Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiler refactor #216

Merged
merged 4 commits into from
Jan 18, 2021
Merged

Tiler refactor #216

merged 4 commits into from
Jan 18, 2021

Conversation

ernestoarbitrio
Copy link
Member

This fix: #215

Furthermore it includes some new refactoring to avoid code fragment duplication and also uniforms names in the Tiler classes

@coveralls
Copy link

coveralls commented Jan 18, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling e7780d1 on refactor-score-tiler into f1c74ae on master.

@ernestoarbitrio ernestoarbitrio added this to In progress in histolab via automation Jan 18, 2021
src/histolab/tiler.py Outdated Show resolved Hide resolved
src/histolab/tiler.py Show resolved Hide resolved
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessiamarcolini alessiamarcolini merged commit 30e8797 into master Jan 18, 2021
histolab automation moved this from In progress to Done Jan 18, 2021
@alessiamarcolini alessiamarcolini deleted the refactor-score-tiler branch January 18, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
histolab
  
Done
Development

Successfully merging this pull request may close these issues.

Refactor ScoreTiler to avoid generating the tiles twice
3 participants