Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stain normalization with Reinhard's method #409

Merged
merged 9 commits into from Jan 14, 2023
Merged

Add stain normalization with Reinhard's method #409

merged 9 commits into from Jan 14, 2023

Conversation

alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented May 26, 2022 •
edited

Description

Add stain normalization with Reinhard's method

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added the enhancement New feature or request label May 26, 2022
@alessiamarcolini alessiamarcolini added this to In progress in histolab via automation May 26, 2022
@alessiamarcolini alessiamarcolini added this to the 0.6.0 milestone May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022 •
edited

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b37ae92) compared to base (c4caa8c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #409   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines         1537      1576   +39     
  Branches       163       165    +2     
=========================================
+ Hits          1537      1576   +39
Impacted Files Coverage Δ
histolab/filters/image_filters_functional.py 100.00% <100.00%> (ø)
histolab/stain_normalizer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ernestoarbitrio
ernestoarbitrio requested changes Jan 14, 2023
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 comment

histolab/stain_normalizer.py Outdated Show resolved Hide resolved
@alessiamarcolini alessiamarcolini merged commit 7c41e05 into master Jan 14, 2023
histolab automation moved this from In progress to Done Jan 14, 2023
@alessiamarcolini alessiamarcolini deleted the reinhard branch January 14, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

@nicolebussola nicolebussola Awaiting requested review from nicolebussola

Assignees
No one assigned
Labels
add-in-next-release enhancement New feature or request
Projects
histolab
  
Done
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Stain Normalization: Reinhard
3 participants
@alessiamarcolini @ernestoarbitrio @nicolebussola