Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relate parameter to Otsuthreshold #415

Merged
merged 1 commit into from Jun 20, 2022

Conversation

bguetarni
Copy link
Contributor

This is related to OtsuThreshold is missing the relate parameter #403.
Adds a relate parameter to be passed to image_filters.OtsuThreshold class.

Description

Added relate arguments in init, and call functional otsu_threshold with.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    I just changed the function documentation.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini self-requested a review June 20, 2022 09:57
@alessiamarcolini alessiamarcolini added the bug Something isn't working label Jun 20, 2022
@alessiamarcolini alessiamarcolini added this to the 0.6.0 milestone Jun 20, 2022
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bguetarni for this contribution 🙌

@alessiamarcolini
Copy link
Collaborator

@ernestoarbitrio the CI is not passing because openslide-python has been updated, I opened PR #416 to support the new version. When that is merged we can rebase this PR on master and then merge it

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #415 (e33dbc7) into master (e33dbc7) will not change coverage.
The diff coverage is n/a.

❗ Current head e33dbc7 differs from pull request most recent head 7c0fcad. Consider uploading reports for the commit 7c0fcad to get more accurate results

@@            Coverage Diff            @@
##            master      #415   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1433      1433           
  Branches       223       223           
=========================================
  Hits          1433      1433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33dbc7...7c0fcad. Read the comment docs.

@alessiamarcolini alessiamarcolini merged commit 60eab31 into histolab:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-in-next-release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OtsuThreshold is missing the relate parameter
3 participants