Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix npm version of "mongodb-backup" and "mongodb-restore" #12

Merged
merged 2 commits into from
Sep 3, 2015
Merged

Conversation

hex7c0
Copy link
Contributor

@hex7c0 hex7c0 commented Sep 2, 2015

the previous version is releated to 1.0.2 on github repo
stream option is available since 1.1.0 version

latest version is released with iojs@3 test

IstoraMandiri added a commit that referenced this pull request Sep 3, 2015
build: fix npm version of "mongodb-backup" and "mongodb-restore"
@IstoraMandiri IstoraMandiri merged commit a24fd65 into IstoraMandiri:master Sep 3, 2015
@IstoraMandiri
Copy link
Owner

Thanks for all your work @hex7c0!

@IstoraMandiri
Copy link
Owner

Will most likely be able to do a new release tomorrow.

@hex7c0
Copy link
Contributor Author

hex7c0 commented Sep 3, 2015

you're welcome

p.s.
there is a typo inside README
https://github.com/hitchcott/app-dump#metoer-app-dump -> meteor
#grammarnazi

@IstoraMandiri
Copy link
Owner

Thanks! I'll correct that too.

BTW, I just tried your fork and I'm getting whenever an error when I try to restore. Looks like drop isn't working properly.

I20150904-11:27:12.956(8)? Error in oplog callback Error: insert found for already-existing ID in published
I20150904-11:27:12.958(8)?     at packages/mongo/oplog_observe_driver.js:562:1
I20150904-11:27:12.959(8)?     at Object.Meteor._noYieldsAllowed (packages/meteor/fiber_helpers.js:11:1)
I20150904-11:27:12.959(8)?     at [object Object]._.extend._handleOplogEntrySteadyOrFetching (packages/mongo/oplog_observe_driver.js:545:1)
I20150904-11:27:12.959(8)?     at packages/mongo/oplog_observe_driver.js:118:1
I20150904-11:27:12.959(8)?     at packages/mongo/oplog_observe_driver.js:16:1
I20150904-11:27:12.959(8)?     at Object.Meteor._noYieldsAllowed (packages/meteor/fiber_helpers.js:11:1)
I20150904-11:27:12.959(8)?     at packages/mongo/oplog_observe_driver.js:106:1
I20150904-11:27:12.959(8)?     at packages/mongo/oplog_tailing.js:79:1
I20150904-11:27:12.959(8)?     at runWithEnvironment (packages/meteor/dynamics_nodejs.js:108:1)
I20150904-11:27:12.959(8)?     at packages/meteor/dynamics_nodejs.js:121:1

I think this is the same reason I was using a forked version of your package; I was manually dropping to prevent that. See IstoraMandiri/mongodb-restore@2e02c75

I think this is a meteor compatibility issue; can we add this as an option in mongodb-restore ?

@hex7c0
Copy link
Contributor Author

hex7c0 commented Sep 4, 2015

mmm, I'm working on it

@hex7c0
Copy link
Contributor Author

hex7c0 commented Sep 4, 2015

now you can use dropCollections: true for simulate drop: true option

I'll release this version tonight
UTC timezone

@hex7c0
Copy link
Contributor Author

hex7c0 commented Sep 4, 2015

hey @hitchcott, try 1.4.0 version

with dropCollections: true
https://github.com/hex7c0/mongodb-restore/blob/master/examples/dropCollections.js#L22

@hex7c0
Copy link
Contributor Author

hex7c0 commented Sep 17, 2015

have you tried updated versions?

@IstoraMandiri
Copy link
Owner

Hi @hex7c0 , sorry I haven't had chance to implement this yet but today is Open Source Friday so let's see what happens ;)

opening an issue for it...

@hex7c0
Copy link
Contributor Author

hex7c0 commented Sep 18, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants