Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning #5

Closed
bomberstudios opened this issue Aug 29, 2016 · 3 comments
Closed

Deprecation warning #5

bomberstudios opened this issue Aug 29, 2016 · 3 comments

Comments

@bomberstudios
Copy link

Hi there.

As you probably know, [MSTextLayer lineSpacing] has been deprecated for a while, and it will be removed in Sketch v40. Please update your Plugin to use [MSTextLayer lineHeight] instead, or it won't work in the next release :)
@bomberstudios
Copy link
Author

BTW, setPatternImage: is also deprecated, so use setImage: instead.

@hite
Copy link
Owner

hite commented Aug 31, 2016

@bomberstudios Thanks bomber for mentions. I am afraid that I have no time to fix it until 7 Sep. As a result of HangZhou G20 Submit, i have a holiday to go back hometown where i have no workshop.
If I was back, I will fix it ASAP.

@hite
Copy link
Owner

hite commented Sep 20, 2016 •
edited

replacing 2 matches of 'lineSpacing' with 'lineHeight'.
replacing 1 matches of 'setPatternImage' with 'setImage'.
Done on V1.2.0 @bomberstudios.

@hite hite closed this as completed Sep 20, 2016
hite added a commit that referenced this issue Sep 20, 2016
@hite
fix:#5
bf4fb47
hite added a commit that referenced this issue Sep 20, 2016
@hite
fix:#5
9ac6139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bomberstudios @hite