only show amount if invoice_items present, refs #425

app/controllers/invoices_controller.rb

@@ -119,8 +119,7 @@ def payment_attrs
   def pdf_options
     {
       articles: params[:articles] != 'false',
-      payment_slip: params[:payment_slip] != 'false',
-      amount: params[:amount] != 'false'
+      payment_slip: params[:payment_slip] != 'false'
     }
   end
 

app/domain/export/pdf/invoice/payment_slip.rb

@@ -12,7 +12,7 @@ def render
       return unless options[:payment_slip]
       invoice_address
       account_number
-      amount if options[:amount]
+      amount if invoice.invoice_items.present?
       esr_number if invoice.ch_esr? || invoice.ch_besr?
       payment_purpose if invoice.ch_es? || invoice.ch_bes?
       receiver_address

app/helpers/dropdown/invoices.rb

@@ -31,12 +31,8 @@ def export
 
     def pdf_links
       add_item(translate(:full), export_path(:pdf), item_options)
-      add_item(translate(:full_without_amount), export_path(:pdf, amount: false), item_options)
       add_item(translate(:articles_only), export_path(:pdf, payment_slip: false), item_options)
       add_item(translate(:esr_only), export_path(:pdf, articles: false), item_options)
-      add_item(translate(:esr_only_without_amount),
-               export_path(:pdf, articles: false, amount: false),
-               item_options)
     end
 
     def label_links

config/locales/views.de.yml

@@ -147,9 +147,7 @@ de:
     print: 'Drucken'
     labels: 'Etiketten'
     full: 'Rechnung inkl. Einzahlungsschein'
-    full_without_amount: 'Rechnung inkl. Einzahlungsschein (ohne Rechnungsbetrag)'
     esr_only: 'Einzahlungsschein separat'
-    esr_only_without_amount: 'Einzahlungsschein separat (ohne Rechnungsbetrag)'
     articles_only: 'Rechnung separat'
     csv: 'CSV'
     pdf: 'PDF'

spec/features/group/invoices_controller_spec.rb

@@ -92,12 +92,6 @@
       expect(page).to have_current_path("/groups/#{group.id}/invoices/#{invoice.id}.pdf")
     end
 
-    it 'exports full invoice without amount' do
-      click_link('Export')
-      click_link('Rechnung inkl. Einzahlungsschein (ohne Rechnungsbetrag)')
-      expect(page).to have_current_path("/groups/#{group.id}/invoices/#{invoice.id}.pdf?amount=false")
-    end
-
     it 'exports only articles' do
       click_link('Export')
       click_link('Rechnung separat')
@@ -109,14 +103,6 @@
       click_link('Einzahlungsschein separat')
       expect(page).to have_current_path("/groups/#{group.id}/invoices/#{invoice.id}.pdf?articles=false")
     end
-
-    it 'exports only esr without amount' do
-      click_link('Export')
-      click_link('Einzahlungsschein separat (ohne Rechnungsbetrag)')
-      expect(page).
-        to have_current_path("/groups/#{group.id}/invoices/#{invoice.id}.pdf?amount=false&articles=false")
-    end
   end
-
 end