Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROUPS: Erweiterung json:api für Gruppen #2243

Closed
4 tasks
Tracked by #301
mtnstar opened this issue Oct 30, 2023 · 1 comment · Fixed by #2253 or hitobito/hitobito_sac_cas#144
Closed
4 tasks
Tracked by #301

GROUPS: Erweiterung json:api für Gruppen #2243

mtnstar opened this issue Oct 30, 2023 · 1 comment · Fixed by #2253 or hitobito/hitobito_sac_cas#144

Comments

@mtnstar
Copy link
Member

mtnstar commented Oct 30, 2023

Das neue json:api soll für Gruppen erweitert werden. Aktuell können über /api Personen (people) managed werden (crud).

Der SAC benötigt vorerst vor allem lesend Zugriff auf Gruppen:

  • Auflisten aller definierten Sektionen und Ortsgruppen (Filter by sti type)
  • Abfragen der sektionsspezifischen Attribute (mounted_attrs) wie z.B. foundation_year, canton, usw.

Mit diesem Ticket sollen die beiden Endpoints GET /api/groups sowie GET /api/groups/:id realisiert werden.

Standardmässig werden archivierte Gruppen nicht aufgelistet. optional kann dies über ein Parameter gemacht werden (falls einfach realisierbar)

GET https://sac-cas.puzzle.ch/api/groups?type=sektion,ortsgruppe

Dieses Format ist nur ein Beispiel, gern generell so nahe wie möglich am Standard von Graphiti bleiben, und das Feature im Core umsetzen.

Attribute

Folgende Gruppen-Attribute sollen auf list/show ausgegeben werden:

  • :id, :parent_id, :name, :short_name, :type, :email, :address, :zip_code, :town, :country, contact_id, :created_at, :updated_at, :deleted_at, :layer_group_id, :creator_id, :updater_id, :deleter_id, :require_person_add_requests, :description,:archived_at, :self_registration_url
  • optional: :logo
  • nur sac wagon: :navision_id, mounted attributes Sektion (foundation_year, canton)

Tech-Spec

ToDo

  • Neuen Controller, route endpoint, graphiti resource, specs
  • Updaten der api doku
  • manuelles Testen z.b. mit curl und/oder dem swagger ui
  • CHANGELOG entry
@carlobeltrame carlobeltrame removed their assignment Oct 31, 2023
@daniel-illi daniel-illi self-assigned this Nov 2, 2023
amaierhofer added a commit that referenced this issue Nov 6, 2023
amaierhofer added a commit that referenced this issue Nov 6, 2023
amaierhofer added a commit that referenced this issue Nov 6, 2023
@amaierhofer amaierhofer linked a pull request Nov 6, 2023 that will close this issue
amaierhofer added a commit that referenced this issue Nov 15, 2023
amaierhofer added a commit that referenced this issue Nov 15, 2023
@daniel-illi
Copy link
Contributor

Also die core changes sehen gut aus und sind IMO bereit zum mergen.
Nun fehlen noch die wagon Anpassungen.

amaierhofer added a commit that referenced this issue Nov 16, 2023
amaierhofer added a commit that referenced this issue Nov 16, 2023
amaierhofer added a commit to hitobito/hitobito_sac_cas that referenced this issue Nov 16, 2023
amaierhofer added a commit to hitobito/hitobito_sac_cas that referenced this issue Nov 16, 2023
amaierhofer added a commit to hitobito/hitobito_sac_cas that referenced this issue Nov 16, 2023
…ments

Add navision and mounted_attrs to group resource

refs hitobito/hitobito#2243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants