Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEOPLE: People::Household cleanup #2624

Open
8 of 12 tasks
daniel-illi opened this issue May 22, 2024 · 1 comment · May be fixed by #2678, hitobito/hitobito_pbs#332 or hitobito/hitobito_sac_cas#616
Open
8 of 12 tasks

PEOPLE: People::Household cleanup #2624

daniel-illi opened this issue May 22, 2024 · 1 comment · May be fixed by #2678, hitobito/hitobito_pbs#332 or hitobito/hitobito_sac_cas#616

Comments

@daniel-illi
Copy link
Contributor

daniel-illi commented May 22, 2024

blocked by #2614, #2616

Mit #2614 wurde das Household implementiert, welches das People::Household ersetzt. Mit diesem ticket sollen alle Referenzen auf People::Household angepasst werden um stattdessen Household zu verwenden und die alte Klasse entfernt werden.

ToDo

  • People::Household entfernen
  • PeopleController:
    • Methoden und dazugehörige callbacks entfernen: #validate_household, #persist_household, #household
    • von self.permitted_attrs das household_people_ids entfernen
  • Person::HouseholdsController entfernen und ebenso dazugehörige Route
  • Person:
    • attr_accessor :household_people_ids entfernen
    • #household_people anpassen: where(id: household_people_ids) aus query entfernen
  • config/settings.yml:221
    • von help_text_blacklist.person das household_people_ids entfernen
  • config/locales:
    • de.person.households entfernen
  • app/views/person/households entfernen
  • in app/views/contactable/_address_fields.html.haml das div updates-household-address anpassen:
    anzeigen, wenn entry eine Person ist und ein household_key gesetzt hat
  • app/javascript/javascripts/modules/people/households.js.coffee entfernen
  • im SAC wagon:
    • in i18n files den Text von contactable.address_fields.updates_household_address anpassen:
      "Adresse wird für alle Familienmitglieder aktualisiert"
  • Specs fixen (diverse Specs benutzen People::Household, um das test setup vorzubereiten)
  • Mit angemessener Rolle "durchklicken"
@daniel-illi daniel-illi self-assigned this May 22, 2024
@daniel-illi daniel-illi removed their assignment May 23, 2024
@amaierhofer amaierhofer self-assigned this Jun 7, 2024
@Largo
Copy link
Contributor

Largo commented Jun 19, 2024

Soll man das reviewen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment